slfan1989 commented on code in PR #13962:
URL: https://github.com/apache/iceberg/pull/13962#discussion_r2320448219
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/SnapshotTableSparkAction.java:
##########
@@ -124,10 +126,10 @@ private SnapshotTable.Result doExecute() {
StagedSparkTable stagedTable = stageDestTable();
Table icebergTable = stagedTable.table();
- // TODO: Check the dest table location does not overlap with the source
table location
Review Comment:
@huaxingao thank you very much for reviewing the code! @RussellSpitzer's
statement is accurate, and I have found the relevant validation code. Apologies
for previously focusing only on the todo and overlooking the existing code
details.
https://github.com/apache/iceberg/blob/170189e17ca0fd423e690d0de52380fa092177fd/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/SnapshotTableSparkAction.java#L217-L223
Should I have the opportunity to update the SnapShot code in the future, I
will remove this todo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
