stevenzwu commented on code in PR #13941:
URL: https://github.com/apache/iceberg/pull/13941#discussion_r2316583302
##########
parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java:
##########
@@ -182,6 +182,7 @@ public Type variant(Type.Repetition repetition, int id,
String originalName) {
shreddedType.getRepetition());
return Types.buildGroup(repetition)
+ .as(LogicalTypeAnnotation.variantType((byte) 1))
Review Comment:
nit: should we use a constant to capture the variant type annotation value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
