ForeverAngry commented on code in PR #2369:
URL: https://github.com/apache/iceberg-python/pull/2369#discussion_r2315876104
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -953,7 +953,7 @@ def _get_protected_snapshot_ids(self) -> Set[int]:
if ref.snapshot_ref_type in [SnapshotRefType.TAG,
SnapshotRefType.BRANCH]
}
- def by_id(self, snapshot_id: int) -> ExpireSnapshots:
+ def by_id(self, snapshot_id: int) -> "ExpireSnapshots":
Review Comment:
Thats a great point. I can log an issue to address these all at one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]