stevie9868 commented on code in PR #2269:
URL: https://github.com/apache/iceberg-python/pull/2269#discussion_r2314113270
##########
pyiceberg/table/__init__.py:
##########
@@ -807,7 +806,7 @@ def upsert(
case_sensitive=case_sensitive,
)
- if branch is not None:
+ if branch in self.table_metadata.refs:
Review Comment:
ah I was thinking for upsert, we also might want to support staging commit
as well so I remove the exception.
Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
