slfan1989 commented on code in PR #13831:
URL: https://github.com/apache/iceberg/pull/13831#discussion_r2312488793
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java:
##########
@@ -116,6 +124,21 @@ private void deleteFiles() {
e);
succeededCounter.inc(deletedFilesCount);
failedCounter.inc(e.numberFailedObjects());
+ } finally {
+ long elapsed = System.currentTimeMillis() - startTime;
+ deleteFileTimeMsHistogram.update(elapsed);
}
}
+
+ public Counter getFailedCounter() {
+ return failedCounter;
+ }
+
+ public Counter getSucceededCounter() {
+ return succeededCounter;
+ }
+
+ public Histogram getDeleteFileTimeMsHistogram() {
+ return deleteFileTimeMsHistogram;
+ }
Review Comment:
> Please remove the get from the method name. See:
https://iceberg.apache.org/contribute/#method-naming
> It might also worth to read through the other style guides as well.
> Also these methods should not be public. They should be package private
and should be annotated with
> @VisibleForTesting annotation. Check the other cases in the Flink code
Thank you for the information! I have improved the code based on your
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
