gabeiglio commented on code in PR #2406:
URL: https://github.com/apache/iceberg-python/pull/2406#discussion_r2312116979


##########
pyiceberg/table/inspect.py:
##########
@@ -226,6 +297,17 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> 
pa.StructType:
         )
 
     def refs(self) -> "pa.Table":
+        """Generate a PyArrow table containing metadata references from a 
table.
+
+        Returns:
+            pa.Table: A PyArraow table with the following schema:

Review Comment:
   ```suggestion
               pa.Table: A PyArrow table with the following schema:
   ```



##########
pyiceberg/table/inspect.py:
##########
@@ -95,6 +127,45 @@ def snapshots(self) -> "pa.Table":
         )
 
     def entries(self, snapshot_id: Optional[int] = None) -> "pa.Table":
+        """Generate and return a table containing manifest entries for a given 
snapshot.
+
+        Args:
+            snapshot_id (Optional[int]): ID of the snapshot to read entries 
from. If None, the current snapshot is used.
+
+        Returns:
+            pa.Table: A PyArraow table where each row represent a manifest 
entry with fields:

Review Comment:
   ```suggestion
               pa.Table: A PyArrow table where each row represent a manifest 
entry with fields:
   ```



##########
pyiceberg/table/inspect.py:
##########
@@ -34,6 +34,12 @@
 
 
 class InspectTable:
+    """A utility class for inspecting and analysing Iceberge table metadata.

Review Comment:
   ```suggestion
       """A utility class for inspecting and analyzing Iceberg table metadata.
   ```



##########
pyiceberg/table/inspect.py:
##########
@@ -319,6 +419,28 @@ def partitions(self, snapshot_id: Optional[int] = None) -> 
"pa.Table":
         )
 
     def _process_manifest(self, manifest: ManifestFile) -> Dict[Tuple[str, 
Any], Any]:
+        """Process a manifest file and extract partition-level statistics.
+
+        Args:
+            manifest: The manifest file containing metadata about data files 
and delete  files.

Review Comment:
   ```suggestion
               manifest: The manifest file containing metadata about data files 
and delete files.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to