RussellSpitzer commented on issue #13218: URL: https://github.com/apache/iceberg/issues/13218#issuecomment-3235047773
> [@RussellSpitzer](https://github.com/RussellSpitzer) The fix is very small and simple, but I think the desired behavior needs to be clear - Is this a confirmed bug or intentional by some reasoning? (this is why I mentioned [@rdblue](https://github.com/rdblue) as the author of the changes). > > As I mentioned before, calling metrics() with `parquetTypeWithIds` "fixes" the issue. Question is if this is the desired behavior. > > 1. it relies on the table properties having schema mappings defined This should be fine if the default name mapping is set > 2. who has the responsibility of populating the table property Traditionally this has been the callers responsibility but we do this automatically for "Snapshot" and "Migrate" commands. > 3. as mentioned, the golang iceberg flavor creates and commits the table property by itself as a side effect when adding a file. I don't think that would really be a problem here either. If the property isn't set, setting it based on the added files seems reasonable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
