stevenzwu commented on code in PR #13720:
URL: https://github.com/apache/iceberg/pull/13720#discussion_r2308595936
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -230,7 +230,8 @@ public void testStartVersion() throws Exception {
.startVersion("v2.metadata.json")
.execute();
- checkFileNum(1, 1, 1, 4, result);
+ // 1 metadata JSON file, 1 snapshot, 2 manifests, 1 data file
+ checkFileNum(1, 1, 2, 5, result);
Review Comment:
To fixing null length in the target table, we should run the rewrite without
starting version to fully restart all manifest files. But we should keep the
incremental behavior the same if starting version is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
