kevinjqliu commented on code in PR #2394:
URL: https://github.com/apache/iceberg-python/pull/2394#discussion_r2307984092
##########
tests/catalog/test_rest.py:
##########
@@ -1496,6 +1496,10 @@ def test_request_session_with_ssl_ca_bundle() -> None:
},
}
with pytest.raises(OSError) as e:
+ if "REQUESTS_CA_BUNDLE" in os.environ:
+ os.environ.pop("REQUESTS_CA_BUNDLE")
+ if "CURL_CA_BUNDLE" in os.environ:
+ os.environ.pop("CURL_CA_BUNDLE")
Review Comment:
nit:
I think `os.environ.pop` mutates the env vars. It might be better to use
[moneypatch.delenv](https://docs.pytest.org/en/stable/reference/reference.html#pytest.MonkeyPatch.delenv)
here
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
