gmweaver commented on PR #2392: URL: https://github.com/apache/iceberg-python/pull/2392#issuecomment-3228904456
> i think theres actually an underlying bug here. endpoint_url here is also part of S3FileSystem constructor. I dont think it should be passed via client_kwargs so, to make things slightly more confusing, `endpoint_url` can be passed to the constructor or in `client_kwargs`. in older versions of `s3fs`, `endpoint_url` was not available in the constructor, so `client_kwargs` may be safer. ``` endpoint_url (string (None)) – Use this endpoint_url, if specified. Needed for connecting to non-AWS S3 buckets. Takes precedence over endpoint_url in client_kwargs. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
