nullccxsy commented on code in PR #194:
URL: https://github.com/apache/iceberg-cpp/pull/194#discussion_r2303515940
##########
test/schema_test.cc:
##########
@@ -51,14 +51,6 @@ TEST(SchemaTest, Basics) {
ASSERT_EQ(std::nullopt, schema.GetFieldByIndex(-1));
ASSERT_EQ(std::nullopt, schema.GetFieldByName("element"));
}
- ASSERT_THAT(
- []() {
- iceberg::SchemaField field1(5, "foo", iceberg::int32(), true);
- iceberg::SchemaField field2(5, "bar", iceberg::string(), true);
- iceberg::Schema schema({field1, field2}, 100);
- },
- ::testing::ThrowsMessage<std::runtime_error>(
Review Comment:
For list's element and map's key, value, do we need to do the same
processing? However, I think it's a bit strange to handle it in
`GetFieldByName()`, they are easy, so I didn't change its exception-throwing
form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
