mccormickt12 commented on code in PR #2291:
URL: https://github.com/apache/iceberg-python/pull/2291#discussion_r2302435026
##########
tests/io/test_pyarrow.py:
##########
@@ -2638,3 +2638,34 @@ def test_retry_strategy_not_found() -> None:
io = PyArrowFileIO(properties={S3_RETRY_STRATEGY_IMPL:
"pyiceberg.DoesNotExist"})
with pytest.warns(UserWarning, match="Could not initialize S3 retry
strategy: pyiceberg.DoesNotExist"):
io.new_input("s3://bucket/path/to/file")
+
+
+def test_parse_location_environment_defaults() -> None:
+ """Test that parse_location uses environment variables for defaults."""
+
+ from pyiceberg.io.pyarrow import PyArrowFileIO
+
+ # Test with default environment (no env vars set)
Review Comment:
fixed
##########
tests/io/test_pyarrow.py:
##########
@@ -2638,3 +2638,34 @@ def test_retry_strategy_not_found() -> None:
io = PyArrowFileIO(properties={S3_RETRY_STRATEGY_IMPL:
"pyiceberg.DoesNotExist"})
with pytest.warns(UserWarning, match="Could not initialize S3 retry
strategy: pyiceberg.DoesNotExist"):
io.new_input("s3://bucket/path/to/file")
+
+
+def test_parse_location_environment_defaults() -> None:
+ """Test that parse_location uses environment variables for defaults."""
+
+ from pyiceberg.io.pyarrow import PyArrowFileIO
+
+ # Test with default environment (no env vars set)
+ scheme, netloc, path = PyArrowFileIO.parse_location("/foo/bar")
+ assert scheme == "file"
+ assert netloc == ""
+ assert path == "/foo/bar"
+
+ # Test with properties set
+ properties = {}
+ properties["DEFAULT_SCHEME"] = "scheme"
+ properties["DEFAULT_NETLOC"] = "netloc:8000"
+
+ scheme, netloc, path = PyArrowFileIO.parse_location("/foo/bar",
properties=properties)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
