kevinjqliu commented on code in PR #2375: URL: https://github.com/apache/iceberg-python/pull/2375#discussion_r2299106728
########## pyiceberg/table/update/__init__.py: ########## @@ -21,9 +21,12 @@ from abc import ABC, abstractmethod from datetime import datetime from functools import singledispatch -from typing import TYPE_CHECKING, Annotated, Any, Dict, Generic, List, Literal, Optional, Set, Tuple, TypeVar, Union, cast +from typing import TYPE_CHECKING, Annotated, Any, Dict, Generic, List, Literal, Optional, Tuple, TypeVar, Union, cast -from pydantic import Field, field_validator, model_validator +from pydantic import Field, field_validator, model_serializer, model_validator + +if TYPE_CHECKING: + from pydantic.functional_serializers import ModelWrapSerializerWithoutInfo Review Comment: nit: we should move this into the other `if TYPE_CHECKING` line on L58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
