huaxingao commented on code in PR #13907:
URL: https://github.com/apache/iceberg/pull/13907#discussion_r2298627317
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##########
@@ -133,7 +133,44 @@ public void removeTables() {
sql("DROP TABLE IF EXISTS %s", tableName(OTHER_TABLE_NAME));
}
- // TODO: add tests for truncate transforms once SPARK-40295 is released
+ // TODO: Truncate is not supported by SPJ yet (even after SPARK-40295).
+ // Add tests for full support once SPARK-50593 is resolved.
Review Comment:
shall we change to something like
```
// TODO: SPJ does not currently leverage truncate(...) partition transforms
for partition alignment.
// SPARK-40295 improved related areas, but full truncate support is tracked
in SPARK-50593.
// This test documents current behavior; update/extend once SPARK-50593
lands.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
