singhpk234 commented on code in PR #13895:
URL: https://github.com/apache/iceberg/pull/13895#discussion_r2298369716
##########
format/spec.md:
##########
@@ -609,14 +609,14 @@ A manifest stores files for a single partition spec. When
a table’s partition
A manifest file must store the partition spec and other metadata as properties
in the Avro file's key-value metadata:
-| v1 | v2 | Key | Value
|
-|------------|------------|---------------------|------------------------------------------------------------------------------|
-| _required_ | _required_ | `schema` | JSON representation of the
table schema at the time the manifest was written |
-| _optional_ | _required_ | `schema-id` | ID of the schema used to
write the manifest as a string |
-| _required_ | _required_ | `partition-spec` | JSON fields representation
of the partition spec used to write the manifest |
-| _optional_ | _required_ | `partition-spec-id` | ID of the partition spec
used to write the manifest as a string |
-| _optional_ | _required_ | `format-version` | Table format version number
of the manifest as a string |
-| | _required_ | `content` | Type of content files
tracked by the manifest: "data" or "deletes" |
+| v1 | v2 | Key | Value
|
+|------------|------------|---------------------|----------------------------------------------------------------------------------------------------|
+| _required_ | _required_ | `schema` | JSON representation of the
table schema at the time the manifest was written |
+| _optional_ | _required_ | `schema-id` | ID of the schema used to
write the manifest as a string |
+| _required_ | _required_ | `partition-spec` | JSON representation of the
partition fields array of the partition spec used to write the manifest |
Review Comment:
[doubt-1] how is the spec-id inferred when the partition-spec-id is empty
(since its optional in v1)
[discuss] is it worth calling out that the ParitionSpec if first converted
to unbounded partition spec whats put here is the unbounded version of
partition field (where transform is just string) rather than Transform object ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
