yeswanth-s1th commented on code in PR #13664:
URL: https://github.com/apache/iceberg/pull/13664#discussion_r2296364538
##########
site/dev/common.sh:
##########
@@ -177,12 +177,12 @@ update_version () {
# Update version information within the mkdocs.yml file using sed commands
if [ "$(uname)" == "Darwin" ]
then
- /usr/bin/sed -i '' -E
"s/(^site\_name:[[:space:]]+docs\/).*$/\1${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
- /usr/bin/sed -i '' -E
"s/(^[[:space:]]*-[[:space:]]+Javadoc:.*\/javadoc\/).*$/\1${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
+ /usr/bin/sed -i '' -E
"s/(^site\_name:[[:space:]]+docs\/).*$/${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
Review Comment:
You’re right. Those sed replacements were corrupted — the \1 backreference
ended up as a control char (^A), and I mistakenly escaped site_name. I’ll fix
both Darwin and Linux blocks to consistently use \1${ICEBERG_VERSION} and quote
paths. No behavior change beyond correcting the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
