anvsk commented on issue #538: URL: https://github.com/apache/iceberg-go/issues/538#issuecomment-3212764482
> Hi [@anvsk](https://github.com/anvsk), I think [#539](https://github.com/apache/iceberg-go/pull/539) fixes this, could you verify? i try and failed again The new code seems to add a validation/guard only. When the input schema only deletes the tail column(s) (i.e., the column(s) with the highest field ID) and we don’t add any new columns, the client now fails that new check immediately and aborts. In other words, the last-assigned-field-id “regression” is detected, but there’s still no way for the client to preserve the previous lastAssignedFieldId for this commit, so the update remains impossible. Either: 1. Re-introduce a way to pass or pin lastAssignedFieldId for AddSchema, or 2. Have the client compute it as max(oldLastId, max(newSchema.FieldIDs)) so it never regresses, or 3. Provide a dedicated update to explicitly set/preserve lastAssignedFieldId during schema evolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
