nastra commented on code in PR #13858:
URL: https://github.com/apache/iceberg/pull/13858#discussion_r2290379265
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java:
##########
@@ -290,7 +291,7 @@ public static String toColumnName(NamedReference ref) {
}
public static boolean caseSensitive(SparkSession spark) {
- return Boolean.parseBoolean(spark.conf().get("spark.sql.caseSensitive"));
+ return
Boolean.parseBoolean(spark.conf().get(SQLConf.CASE_SENSITIVE().key()));
Review Comment:
@guixiaowen I'm counting 30 places across the entire Iceberg codebase that
use the hardcoded string, so we should update all of those places if we're
going to update it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
