wgtmac commented on code in PR #187: URL: https://github.com/apache/iceberg-cpp/pull/187#discussion_r2289875032
########## src/iceberg/type_fwd.h: ########## @@ -127,16 +127,29 @@ struct ManifestList; class ManifestReader; class ManifestListReader; +class ManifestWriter; +class ManifestListWriter; -/// ---------------------------------------------------------------------------- -/// TODO: Forward declarations below are not added yet. -/// ---------------------------------------------------------------------------- +class Reader; +class Writer; -class StructLike; +class Avro; Review Comment: ```suggestion ``` ########## src/iceberg/type_fwd.h: ########## @@ -127,16 +127,29 @@ struct ManifestList; class ManifestReader; class ManifestListReader; +class ManifestWriter; +class ManifestListWriter; -/// ---------------------------------------------------------------------------- -/// TODO: Forward declarations below are not added yet. -/// ---------------------------------------------------------------------------- +class Reader; +class Writer; -class StructLike; +class Avro; + +class ScanTask; +class DataTableScan; + +class Literal; + +class IcebergError; +class True; +class False; +class And; +class Or; Review Comment: ```suggestion ``` We don't need these. Usually `Expression` is enough. ########## src/iceberg/type_fwd.h: ########## @@ -127,16 +127,29 @@ struct ManifestList; class ManifestReader; class ManifestListReader; +class ManifestWriter; +class ManifestListWriter; -/// ---------------------------------------------------------------------------- -/// TODO: Forward declarations below are not added yet. -/// ---------------------------------------------------------------------------- +class Reader; +class Writer; -class StructLike; +class Avro; + +class ScanTask; +class DataTableScan; + +class Literal; Review Comment: Move it to nearby `Expression`. ########## src/iceberg/type_fwd.h: ########## @@ -127,16 +127,29 @@ struct ManifestList; class ManifestReader; class ManifestListReader; +class ManifestWriter; Review Comment: Sort them alphabetically? ########## src/iceberg/type_fwd.h: ########## @@ -127,16 +127,29 @@ struct ManifestList; class ManifestReader; class ManifestListReader; +class ManifestWriter; +class ManifestListWriter; -/// ---------------------------------------------------------------------------- -/// TODO: Forward declarations below are not added yet. -/// ---------------------------------------------------------------------------- +class Reader; +class Writer; -class StructLike; +class Avro; + +class ScanTask; Review Comment: Move these two to `FileScanTask` section? ########## src/iceberg/type_fwd.h: ########## @@ -127,16 +127,29 @@ struct ManifestList; class ManifestReader; class ManifestListReader; +class ManifestWriter; +class ManifestListWriter; -/// ---------------------------------------------------------------------------- -/// TODO: Forward declarations below are not added yet. -/// ---------------------------------------------------------------------------- +class Reader; +class Writer; -class StructLike; +class Avro; + +class ScanTask; +class DataTableScan; + +class Literal; + +class IcebergError; Review Comment: ```suggestion ``` We don't need this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
