rdblue commented on code in PR #12634:
URL: https://github.com/apache/iceberg/pull/12634#discussion_r2288799391
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestPruneColumns.java:
##########
@@ -237,6 +238,26 @@ public void testStructElementName() {
.named("z"))
.id(6)
.named("struct_name_2"))
+ .addField(
Review Comment:
Existing tests should not be modified to validate new behavior. Please write
a new test case that exercises the new behavior. If the change modifies the
behavior of existing tests, then it's fine to update them. But we want to only
change existing tests to pass -- that way reviewers can see all of the behavior
changes that result from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
