dongxiao1198 commented on code in PR #176:
URL: https://github.com/apache/iceberg-cpp/pull/176#discussion_r2287786229
##########
src/iceberg/manifest_writer.h:
##########
@@ -35,14 +35,57 @@ namespace iceberg {
class ICEBERG_EXPORT ManifestWriter {
public:
virtual ~ManifestWriter() = default;
- virtual Status WriteManifestEntries(
- const std::vector<ManifestEntry>& entries) const = 0;
+
+ /// \brief Write manifest entry to file.
+ /// \param entry Manifest entry to write.
+ /// \return Status::OK() if entry was written successfully
+ virtual Status Add(const ManifestEntry& entry) = 0;
Review Comment:
1 this way can hide adapter and constructor inside
2 We may create gmock class for test in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
