Guosmilesmile commented on code in PR #13831:
URL: https://github.com/apache/iceberg/pull/13831#discussion_r2287244841
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java:
##########
@@ -76,6 +79,10 @@ public void open() throws Exception {
taskMetricGroup.counter(TableMaintenanceMetrics.DELETE_FILE_FAILED_COUNTER);
this.succeededCounter =
taskMetricGroup.counter(TableMaintenanceMetrics.DELETE_FILE_SUCCEEDED_COUNTER);
+ this.deleteFileTimeMsHistogram =
+ taskMetricGroup.histogram(
+ TableMaintenanceMetrics.DELETE_FILE_TIME_MS_HISTOGRAM,
+ new DescriptiveStatisticsHistogram(1000));
Review Comment:
In my use case, I haven't focused on the time it takes to delete files. The
only time I've encountered long deletion times is when IO is high, and in those
cases, write performance or machine metrics would directly reflect the issue.
@slfan1989 Could you describe the specific scenario you're dealing with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
