Fokko commented on code in PR #2343:
URL: https://github.com/apache/iceberg-python/pull/2343#discussion_r2285105756
##########
pyiceberg/table/update/__init__.py:
##########
@@ -756,6 +756,13 @@ def validate(self, base_metadata: Optional[TableMetadata])
-> None:
elif self.snapshot_id is not None:
raise CommitFailedException(f"Requirement failed: branch or tag
{self.ref} is missing, expected {self.snapshot_id}")
+ # override the override method, allowing None to serialize to `null`
instead of being omitted.
+ def model_dump_json(
+ self, exclude_none: bool = False, exclude: Optional[Set[str]] = None,
by_alias: bool = True, **kwargs: Any
+ ) -> str:
+ return super().model_dump_json(
+ exclude_none=exclude_none,
exclude=self._exclude_private_properties(exclude), by_alias=by_alias, **kwargs
+ )
Review Comment:
```suggestion
# `snapshot-id` is required in json response, even if null
return super().model_dump_json(exclude_none=False)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
