kevinjqliu commented on PR #2333: URL: https://github.com/apache/iceberg-python/pull/2333#issuecomment-3199114662
Thanks for the link @Fokko, that was very helpful. > I think supporting UTC should be safe (that was the intend of https://github.com/apache/iceberg-python/pull/910), but anything other than UTC is not supported (and probably should be rewritten). I agree. I included a fix in this PR. It mirrors the logic reading timestamps types [here](https://github.com/apache/iceberg-python/blob/8b43eb88fcc80b4980ce16b71852d211d7e93b13/pyiceberg/io/pyarrow.py#L1330-L1353) > Do we know how Java handles this? I think its this. Timestamptz is read as a long and [converted to `OffsetDateTime`](https://github.com/apache/iceberg/blob/856cbf6eb8a85dee01c65ae6291274b700f76746/core/src/main/java/org/apache/iceberg/data/avro/GenericReaders.java#L107-L116), with [default UTC timetzone](https://github.com/apache/iceberg/blob/856cbf6eb8a85dee01c65ae6291274b700f76746/api/src/main/java/org/apache/iceberg/util/DateTimeUtil.java#L35). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
