Fokko commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2283453685
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTestBase.java:
##########
@@ -109,8 +110,8 @@ protected boolean supportsRowLineage() {
required(114, "dec_9_0", Types.DecimalType.of(9, 0)), // int encoded
required(115, "dec_11_2", Types.DecimalType.of(11, 2)), // long
encoded
required(116, "dec_20_5", Types.DecimalType.of(20, 5)), // requires
padding
- required(117, "dec_38_10", Types.DecimalType.of(38, 10)) // Spark's
maximum precision
- );
+ required(117, "dec_38_10", Types.DecimalType.of(38, 10)), // Spark's
maximum precision
+ optional(118, "unk", Types.UnknownType.get()));
Review Comment:
That case is covered by:
https://github.com/apache/iceberg/blob/0d26e1f1eec1ff67d4633b4bc38cd7ceb65a99a2/spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTestBase.java#L162-L164
I've added the `UnknownType` to `SIMPLE_TYPES` as well, and also used that
test-case to debug most of the code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
