xixipi-lining opened a new pull request, #535:
URL: https://github.com/apache/iceberg-go/pull/535

   ### Description
   
   This PR removes the requirement for the `database_type` parameter in both 
`ListNamespaces` and `CreateNamespace` operations for the Glue catalog to align 
with the Java and Python versions of Apache Iceberg.
   
   ### Background
   
   After reviewing the Java and Python implementations of Apache Iceberg, we 
found that neither version uses the `database_type` parameter in their Glue 
catalog operations. The Go implementation was unnecessarily handling this 
parameter, which was inconsistent with the reference implementations.
   
   This inconsistency caused a practical issue: namespaces created using 
pyiceberg could not be listed in the Go implementation because pyiceberg 
doesn't set the `database_type` parameter, while the Go version required it for 
filtering.
   
   ### Changes
   
   - **ListNamespaces**: Removed filtering logic that checked `database_type` 
in database parameters
   - **CreateNamespace**: Removed the `database_type` parameter from database 
creation
   - Updated to use AWS SDK paginator for improved reliability
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to