kevinjqliu commented on PR #2266: URL: https://github.com/apache/iceberg-python/pull/2266#issuecomment-3194633913
There are 2 other usages of `ManifestEntry.from_args` stood out to me. * This one in [`ManifestWriter.delete`](https://github.com/apache/iceberg-python/blob/80135451d030569259d83674ef147e0d6f62fd51/pyiceberg/manifest.py#L1104-L1113) uses `self._snapshot_id` which i think is correct. * This one in [`_OverwriteFiles._get_entries`](https://github.com/apache/iceberg-python/blob/80135451d030569259d83674ef147e0d6f62fd51/pyiceberg/table/update/snapshot.py#L631-L641) fetches previous snapshots manifest entries, so we dont need to worry about this one. All other references of `ManifestEntry.from_args` are unrelated to deletes. Looks like we covered all the cases, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
