laskoviymishka commented on code in PR #527:
URL: https://github.com/apache/iceberg-go/pull/527#discussion_r2280966446
##########
table/requirement_test.go:
##########
@@ -145,3 +147,214 @@ func TestParseRequirementList(t *testing.T) {
assert.Error(t, err)
})
}
+
+// mockMetadata is a correct and complete mock implementation of the
+// table.Metadata interface, used for testing requirement validation.
+type mockMetadata struct {
Review Comment:
this is not a mock, this is fake, take a look
[here](https://martinfowler.com/bliki/TestDouble.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
