stevenzwu commented on code in PR #13827:
URL: https://github.com/apache/iceberg/pull/13827#discussion_r2279693662
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsCoordinator.java:
##########
@@ -277,7 +277,7 @@ private void handleRequestGlobalStatisticsEvent(int
subtask, RequestGlobalStatis
if (globalStatistics != null) {
runInCoordinatorThread(
() -> {
- if (event.signature() != null && event.signature() !=
globalStatistics.hashCode()) {
+ if (event.signature() != null && event.signature() ==
globalStatistics.hashCode()) {
Review Comment:
thx for catching the bug. I think your fix is correct.
Should we also fix the log message as following?
```
Skip responding to statistics request from subtask {}, as the operator task
already holds the same global statistics
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
