RussellSpitzer commented on code in PR #13820:
URL: https://github.com/apache/iceberg/pull/13820#discussion_r2279752933
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -101,6 +102,9 @@ public class RewriteDataFilesSparkAction
super(((org.apache.spark.sql.classic.SparkSession) spark).cloneSession());
// Disable Adaptive Query Execution as this may change the output
partitioning of our write
spark().conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(), false);
+ // Disable executor cache for delete files as each partition is rewritten
separately,
+ // so caching delete files across partitions provides no benefit for
rewrites
+ spark().conf().set(SparkSQLProperties.EXECUTOR_CACHE_DELETE_FILES_ENABLED,
"false");
Review Comment:
There is one case when we wouldn't want to do this I think, which is if we
are compacting to a target spec from non-target specs. When we do that we do
actually group data from multiple partitions together. It's probably fine to
just leave this as false though for now and if we get any future feedback we
can address it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
