danielcweeks commented on code in PR #13619:
URL: https://github.com/apache/iceberg/pull/13619#discussion_r2279276530
##########
core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java:
##########
@@ -94,6 +94,7 @@ public void accept(ErrorResponse error) {
throw new CommitFailedException("Commit failed: %s",
error.message());
case 500:
case 502:
+ case 503:
Review Comment:
I think the concern is that we're being conservative on what we consider
erroneous and very aggressive about cleaning up in these cases. We've been
through this same issue multiple times now around 5XX codes and if we consider
the commit state unknown for all 5XX codes, the only downside is that we leave
more files around. The side-effect of being too aggressive on cleanup is that
we break a table, which is the worst option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
