nastra commented on code in PR #13740:
URL: https://github.com/apache/iceberg/pull/13740#discussion_r2278446194
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSnapshotUpdateSparkAction.java:
##########
@@ -38,10 +39,12 @@ public ThisT snapshotProperty(String property, String
value) {
protected void commit(org.apache.iceberg.SnapshotUpdate<?> update) {
summary.forEach(update::set);
+ update.set(SparkWriteUtil.SPARK_APP_ID,
spark().sparkContext().applicationId());
Review Comment:
even then I don't think we need to update the snapshot summary manually to
pass the application ID when we have already a central place where we could do
that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
