wgtmac commented on code in PR #165:
URL: https://github.com/apache/iceberg-cpp/pull/165#discussion_r2275229555
##########
src/iceberg/parquet/parquet_reader.cc:
##########
@@ -227,6 +224,8 @@ class ParquetReader::Impl {
}
private:
+ // TODO(gangwu): make memory pool configurable
Review Comment:
I don't have well-thought opinion here. `ReaderOptions` basically cannot
expose any Arrow-related concept. Maybe we cannot avoid introducing a
MemoryPool interface which is similar to FileIO whose default implementation is
backed by Arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
