zeroshade commented on code in PR #533:
URL: https://github.com/apache/iceberg-go/pull/533#discussion_r2273749785
##########
table/metadata_internal_test.go:
##########
@@ -949,3 +951,16 @@ func TestMetadataV2Validation(t *testing.T) {
// Test case 3: Verify LastColumnId maintains 0 when explicitly set
require.NoError(t, meta3.UnmarshalJSON([]byte(zeroColumnID)))
}
+
+func getTestTableMetadata(fileName string) (Metadata, error) {
+ fCont, err := os.ReadFile(path.Join("../test_table_metadata", fileName))
Review Comment:
use a `testdata` folder inside of the `table` package for this. `testdata`
is a specially recognized folder by the Go toolchain for placing data files
that are needed for tests without complicating the packaging/module stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
