dongxiao1198 commented on code in PR #173:
URL: https://github.com/apache/iceberg-cpp/pull/173#discussion_r2273012326
##########
src/iceberg/file_writer.h:
##########
@@ -65,6 +67,20 @@ class ICEBERG_EXPORT Writer {
///
/// \return Status of write results.
virtual Status Write(ArrowArray data) = 0;
+
+ /// \brief Get the file statistics.
+ /// Only valid after the file is closed.
+ virtual Metrics metrics() = 0;
Review Comment:
Actually it should be , internal implement will check whether the stream is
closed, if not return null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
