Guosmilesmile commented on code in PR #13795:
URL: https://github.com/apache/iceberg/pull/13795#discussion_r2272090073
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -46,6 +44,7 @@ public class ZkLockFactory implements TriggerLockFactory {
private transient CuratorFramework client;
private transient SharedCount taskSharedCount;
private transient SharedCount recoverySharedCount;
+ private volatile boolean isOpen = false;
Review Comment:
Should we change the status in `close()` ? Otherwise, it will remain in an
open state.
##########
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java:
##########
@@ -222,6 +223,8 @@ public void testAllNulls() {
shouldRead = new InclusiveMetricsEvaluator(SCHEMA,
notNull("no_nulls")).eval(FILE);
assertThat(shouldRead).as("Should read: non-null column contains a
non-null value").isTrue();
+
+ assertEquals(1, 1);
Review Comment:
Do we need this? Is there some mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
