Fokko commented on code in PR #2269:
URL: https://github.com/apache/iceberg-python/pull/2269#discussion_r2266224077
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -118,6 +119,7 @@ def __init__(
commit_uuid: Optional[uuid.UUID] = None,
snapshot_properties: Dict[str, str] = EMPTY_DICT,
branch: str = MAIN_BRANCH,
+ stage_only: bool = False,
Review Comment:
I think API wise, this makes more sense. In the case `branch is None` then
we don't set the ref, if it is `not None` then we set the ref.
```suggestion
branch: Optional[str] = MAIN_BRANCH
```
@kevinjqliu WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
