davseitsev commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2265384942
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java:
##########
@@ -29,22 +29,27 @@ public enum SparkCatalogConfig {
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
- "default-namespace", "default")),
+ "default-namespace", "default",
+ "unique-table-location", "true")),
HADOOP(
"testhadoop",
SparkCatalog.class.getName(),
ImmutableMap.of("type", "hadoop", "cache-enabled", "false")),
REST(
"testrest",
SparkCatalog.class.getName(),
- ImmutableMap.of("type", "rest", "cache-enabled", "false")),
+ ImmutableMap.of(
+ "type", "rest",
+ "cache-enabled", "false",
+ "unique-table-location", "true")),
SPARK(
"spark_catalog",
SparkSessionCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
"default-namespace", "default",
"parquet-enabled", "true",
+ "unique-table-location", "true",
Review Comment:
Done. I extracted my test to TestUniqueLocation.java and added more tests
covering important corner cases with overlapping tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
