kevinjqliu commented on code in PR #13750:
URL: https://github.com/apache/iceberg/pull/13750#discussion_r2264920291
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -92,9 +95,14 @@ private CatalogContext initializeBackendCatalog() throws
IOException {
LOG.info("No warehouse location set. Defaulting to temp location: {}",
warehouseLocation);
}
+ // Get catalog name from environment or use default
+ String catalogName =
+ PropertyUtil.propertyAsString(catalogProperties, CATALOG_NAME,
CATALOG_NAME_DEFAULT);
+ LOG.info("Using catalog name: {}", catalogName);
+
LOG.info("Creating catalog with properties: {}", catalogProperties);
return new CatalogContext(
- CatalogUtil.buildIcebergCatalog("rest_backend", catalogProperties, new
Configuration()),
+ CatalogUtil.buildIcebergCatalog(catalogName, catalogProperties, new
Configuration()),
Review Comment:
afaik the catalog name is just a placeholder and not used for anything. i
dont think we even reference the catalog by name.
for example, in the RCKUtils class, the name is set to another string
constant
https://github.com/apache/iceberg/blob/c8c61a3f6b60499f09e5047c5c9d8a3c02d9fb72/open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java#L122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
