mccormickt12 commented on code in PR #2291:
URL: https://github.com/apache/iceberg-python/pull/2291#discussion_r2261093449
##########
pyiceberg/io/pyarrow.py:
##########
@@ -381,21 +381,38 @@ def to_input_file(self) -> PyArrowFile:
class PyArrowFileIO(FileIO):
fs_by_scheme: Callable[[str, Optional[str]], FileSystem]
+ config: Config
def __init__(self, properties: Properties = EMPTY_DICT):
self.fs_by_scheme: Callable[[str, Optional[str]], FileSystem] =
lru_cache(self._initialize_fs)
+ self.config = Config()
super().__init__(properties=properties)
@staticmethod
- def parse_location(location: str) -> Tuple[str, str, str]:
- """Return the path without the scheme."""
+ def parse_location(location: str, config: Config) -> Tuple[str, str, str]:
+ """Return (scheme, netloc, path) for the given location.
+
+ Uses environment variables DEFAULT_SCHEME and DEFAULT_NETLOC
+ if scheme/netloc are missing.
+ """
uri = urlparse(location)
- if not uri.scheme:
- return "file", uri.netloc, os.path.abspath(location)
- elif uri.scheme in ("hdfs", "viewfs"):
- return uri.scheme, uri.netloc, uri.path
+
+ # Load defaults from environment
+ default_scheme = config.get_str("default-scheme") or "file"
+ default_netloc = config.get_str("default-netloc") or ""
+
+ # Apply logic
+ scheme = uri.scheme or default_scheme
+ netloc = uri.netloc or default_netloc
+
+ if scheme in ("hdfs", "viewfs"):
+ return scheme, netloc, uri.path
else:
- return uri.scheme, uri.netloc, f"{uri.netloc}{uri.path}"
+ # For non-HDFS URIs, include netloc in the path if present
+ path = uri.path if uri.scheme else os.path.abspath(location)
+ if netloc and not path.startswith(netloc):
+ path = f"{netloc}{path}"
+ return scheme, netloc, path
Review Comment:
i don't see a nice way to do this since the path used in the pyarrowfile is
actually different in the different cases, i tried to see if we could use the
same path with netloc in it for hdfs but it doesn't seem to work
https://github.com/apache/iceberg-python/pull/2291#issuecomment-3165111733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
