yguy-ryft commented on code in PR #13432: URL: https://github.com/apache/iceberg/pull/13432#discussion_r2259807451
########## docs/docs/maintenance.md: ########## @@ -63,20 +63,25 @@ Expiring old snapshots removes them from metadata, so they are no longer availab ### Remove old metadata files -Iceberg keeps track of table metadata using JSON files. Each change to a table produces a new metadata file to provide atomicity. +Iceberg keeps track of table metadata using JSON files. Each change to a table produces a new metadata file to provide atomicity. -Old metadata files are kept for history by default. Tables with frequent commits, like those written by streaming jobs, may need to regularly clean metadata files. +Old metadata files are kept for history by default. Tables with frequent commits, like those written by streaming jobs, may need to regularly clean metadata files to reduce metadata overhead. Review Comment: You're right. I was looking for a way to emphasize what's the purpose of cleaning metadata files, but I guess it's redundant. I removed this addition ########## docs/docs/maintenance.md: ########## @@ -63,20 +63,25 @@ Expiring old snapshots removes them from metadata, so they are no longer availab ### Remove old metadata files -Iceberg keeps track of table metadata using JSON files. Each change to a table produces a new metadata file to provide atomicity. +Iceberg keeps track of table metadata using JSON files. Each change to a table produces a new metadata file to provide atomicity. -Old metadata files are kept for history by default. Tables with frequent commits, like those written by streaming jobs, may need to regularly clean metadata files. +Old metadata files are kept for history by default. Tables with frequent commits, like those written by streaming jobs, may need to regularly clean metadata files to reduce metadata overhead. Review Comment: You're right. I was looking for a way to emphasize what's the purpose of cleaning metadata files, but I guess it's redundant. I removed this addition 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
