danielcweeks commented on code in PR #13694:
URL: https://github.com/apache/iceberg/pull/13694#discussion_r2258437684
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -237,12 +237,13 @@ protected ManifestEntry<DataFile>
prepare(ManifestEntry<DataFile> entry) {
@Override
protected FileAppender<ManifestEntry<DataFile>> newAppender(
PartitionSpec spec, OutputFile file) {
- Schema manifestSchema = V4Metadata.entrySchema(spec.partitionType());
+ Schema manifestSchema = V4Metadata.entrySchema(spec);
try {
+ Schema schema = spec.schema();
return InternalData.write(FileFormat.AVRO, file)
.schema(manifestSchema)
.named("manifest_entry")
- .meta("schema", SchemaParser.toJson(spec.schema()))
+ .meta("schema", SchemaParser.toJson(schema))
Review Comment:
We probably don't want to be writing the full schema anymore since it's not
really used anywhere. I would suggest we swap this for the schema id (we can
still tie this back to the table schema used at that point). Putting this in
the file footer really increases the size of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
