zeroshade commented on code in PR #521:
URL: https://github.com/apache/iceberg-go/pull/521#discussion_r2257793030
##########
name_mapping.go:
##########
@@ -130,6 +130,122 @@ func visitMappedFields[S, T any](fields []MappedField,
visitor NameMappingVisito
return visitor.Fields(fields, results)
}
+func UpdateNameMapping(nameMapping NameMapping, updates map[int]NestedField,
adds map[int][]NestedField) (NameMapping, error) {
+ result, err := VisitNameMapping(nameMapping,
&updateNameMappingVisitor{updates: updates, adds: adds})
Review Comment:
Add a docstsring comment here to explain the benefits of using this vs just
`CreateNameMapping` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
