CTTY commented on code in PR #1580: URL: https://github.com/apache/iceberg-rust/pull/1580#discussion_r2255358972
########## crates/catalog/loader/src/lib.rs: ########## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; +use std::sync::Arc; + +use async_trait::async_trait; +use iceberg::{Catalog, CatalogBuilder, Error, ErrorKind, Result}; +use iceberg_catalog_rest::RestCatalogBuilder; + +#[async_trait] +pub trait BoxedCatalogBuilder { Review Comment: Sorry I meant the common code like this can be put under `crates/iceberg/src/catalog/mod.rs`. I don't see the need of adding another module here, maybe I'm missing anything? Also I'm thinking if `Box<Self>` will be common across all catalog builders, maybe we can just change the `CatalogBuilder` trait to be `self: Arc<Self>` or `self: Box<Self>`, so we don't need to define a wrapper trait like this, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
