pvary commented on code in PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#discussion_r2254332093
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2698,6 +2706,77 @@ public void
testTableExistsFallbackToGETRequestWithLegacyServer() {
verifyTableExistsFallbackToGETRequest(ConfigResponse.builder().build());
}
+ @Test
+ public void testETagResponseHeader() {
+ Map<String, String> respHeaders = Maps.newConcurrentMap();
+
+ RESTCatalogAdapter adapter =
+ new RESTCatalogAdapter(backendCatalog) {
+ @Override
+ public <T extends RESTResponse> T execute(
+ HTTPRequest request,
+ Class<T> responseType,
+ Consumer<ErrorResponse> errorHandler,
+ Consumer<Map<String, String>> responseHeaders) {
+ return super.execute(request, responseType, errorHandler,
respHeaders::putAll);
+ }
+ };
+
+ RESTCatalog catalog = catalog(adapter);
+
+ if (requiresNamespaceCreate()) {
+ catalog.createNamespace(TABLE.namespace());
+ }
+
+ // Verifies that createTable and loadTable gives the same ETag response
header
Review Comment:
I would split these to different test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
