nastra commented on code in PR #13730:
URL: https://github.com/apache/iceberg/pull/13730#discussion_r2253989412
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAzureSasCredentialPolicy.java:
##########
@@ -30,8 +30,8 @@
class VendedAzureSasCredentialPolicy implements HttpPipelinePolicy {
private final String account;
private final VendedAdlsCredentialProvider vendedAdlsCredentialProvider;
- private AzureSasCredential azureSasCredential;
- private AzureSasCredentialPolicy azureSasCredentialPolicy;
+ private volatile AzureSasCredential azureSasCredential;
+ private volatile AzureSasCredentialPolicy azureSasCredentialPolicy;
Review Comment:
the double-checked locking only applies to `azureSasCredential`, so I don't
think this one needs to be made volatile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
