wgtmac commented on code in PR #159:
URL: https://github.com/apache/iceberg-cpp/pull/159#discussion_r2253672707
##########
test/parquet_schema_test.cc:
##########
@@ -50,17 +136,375 @@ TEST(HasFieldIds, PrimitiveNode) {
TEST(HasFieldIds, GroupNode) {
auto group_node_without_field_id =
MakeGroupNode("test_group", {MakeInt32Node("c1"), MakeInt32Node("c2")});
- EXPECT_FALSE(HasFieldIds(group_node_without_field_id));
+ EXPECT_FALSE(HasFieldIds(group_node_without_field_id)); // NOLINT
auto group_node_with_full_field_id = MakeGroupNode(
"test_group",
{MakeInt32Node("c1", /*field_id=*/2), MakeInt32Node("c2",
/*field_id=*/3)},
/*field_id=*/1);
- EXPECT_TRUE(HasFieldIds(group_node_with_full_field_id));
+ EXPECT_TRUE(HasFieldIds(group_node_with_full_field_id)); // NOLINT
auto group_node_with_partial_field_id = MakeGroupNode(
"test_group", {MakeInt32Node("c1", /*field_id=*/1),
MakeInt32Node("c2")});
- EXPECT_TRUE(HasFieldIds(group_node_with_partial_field_id));
+ EXPECT_TRUE(HasFieldIds(group_node_with_partial_field_id)); // NOLINT
Review Comment:
Agreed. I'm still investigating so it is not finalized yet.
FTR: bumping clang-tidy version from 19 to 22 does eliminate errors from 8
to 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
