dentiny commented on code in PR #1578:
URL: https://github.com/apache/iceberg-rust/pull/1578#discussion_r2252173214
##########
crates/iceberg/src/delete_vector.rs:
##########
@@ -43,6 +43,14 @@ impl DeleteVector {
self.inner.insert(pos)
}
+ /// Return whether append positions into delete vectors succeeds.
+ #[allow(dead_code)]
+ pub fn append_positions(&mut self, positions: &[u64]) -> bool {
+ let expected_num = positions.len();
+ let appended_num =
self.inner.append(positions.iter().copied()).unwrap();
+ appended_num as usize == expected_num
Review Comment:
Thanks for the comment!
Yeah I think it's too specific for my use case (which guarantees no
duplicates and ordering).
In the latest commit, I updated the return value to items inserted:
- It matches the interface for roaring bitmap
- For my own usage, I do want to assert no duplicate insertions
Let me know if you're fine with it, thank you for the quick review and
constructive comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
