sungwy commented on code in PR #2244:
URL: https://github.com/apache/iceberg-python/pull/2244#discussion_r2251486379
##########
pyiceberg/catalog/rest/auth.py:
##########
@@ -187,3 +289,4 @@ def create(cls, class_or_name: str, config: Dict[str, Any])
-> AuthManager:
AuthManagerFactory.register("noop", NoopAuthManager)
AuthManagerFactory.register("basic", BasicAuthManager)
AuthManagerFactory.register("legacyoauth2", LegacyOAuth2AuthManager)
+AuthManagerFactory.register("oauth2", OAuth2AuthManager)
Review Comment:
My understanding is that with Python `import` the module's code is executed
only once, and subsequent imports instructs Python to retrieve the loaded
module object from `sys.modules` unless the application owner intentionaly
reloads the module. The registration is also currently
[idempotent](https://github.com/apache/iceberg-python/blob/ccaa15cf8ac1eb1202256d17efc9cf9d20723d20/pyiceberg/catalog/rest/auth.py#L159)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
