danielcweeks commented on code in PR #13699:
URL: https://github.com/apache/iceberg/pull/13699#discussion_r2249002337
##########
arrow/src/main/java/org/apache/iceberg/arrow/ArrowSchemaUtil.java:
##########
@@ -51,94 +54,133 @@ private ArrowSchemaUtil() {}
public static Schema convert(final org.apache.iceberg.Schema schema) {
ImmutableList.Builder<Field> fields = ImmutableList.builder();
- for (NestedField f : schema.columns()) {
- fields.add(convert(f));
+ for (NestedField field : schema.columns()) {
+ fields.add(TypeUtil.visit(field.type(), new
IcebergToArrowTypeConverter(field)));
Review Comment:
I think I remember now that arrow doesn't have a top-level structure that
you can build incrementally. This actually looks similar to how we do some of
the avro conversion, so I think this is probably fine to keep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
